[ 
https://issues.apache.org/jira/browse/THRIFT-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669718#action_12669718
 ] 

Kevin Clark commented on THRIFT-302:
------------------------------------

It's being used:

sisyphus:~/code/thrift kev$ g g strlcpy
lib/rb/ext/extconf.rb:have_func("strlcpy", "string.h")
lib/rb/ext/struct.c:  strlcpy(&name_buf[1], RSTRING(field_name)->ptr, sizeof(nam
lib/rb/ext/struct.c:  strlcpy(&name_buf[1], RSTRING(field_name)->ptr, sizeof(nam

in get_field_value (232) and set_field_value (416).

> Native extension fails to build
> -------------------------------
>
>                 Key: THRIFT-302
>                 URL: https://issues.apache.org/jira/browse/THRIFT-302
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Esteve Fernandez
>            Priority: Critical
>         Attachments: ruby_ext_errors.log, thrift-302.patch
>
>
> The Ruby native extension fails to build in Linux (Ubuntu 8.04) due to:
> - files not ending in a newline (just a warning, but make aborts since 
> extconf.rb uses -Werror)
> - strlcpy not being available in Linux. I've replaced it with strncpy, 
> although it's not exactly the same. If we want to use the former, strlcpy's 
> source code should be included.
> - uint8_t, uint32_t, etc. not found. I just added stdint.h to 
> binary_protocol_accelerated.c

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to