Looks clean, +1 On Tue, Feb 3, 2009 at 10:28 AM, Esteve Fernandez (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/THRIFT-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Esteve Fernandez updated THRIFT-302: > ------------------------------------ > > Attachment: thrift-302_v2.patch > > This patch includes strlcpy's source code and uses it instead of strncpy > >> Native extension fails to build >> ------------------------------- >> >> Key: THRIFT-302 >> URL: https://issues.apache.org/jira/browse/THRIFT-302 >> Project: Thrift >> Issue Type: Bug >> Components: Library (Ruby) >> Reporter: Esteve Fernandez >> Priority: Critical >> Attachments: ruby_ext_errors.log, thrift-302.patch, >> thrift-302_v2.patch >> >> >> The Ruby native extension fails to build in Linux (Ubuntu 8.04) due to: >> - files not ending in a newline (just a warning, but make aborts since >> extconf.rb uses -Werror) >> - strlcpy not being available in Linux. I've replaced it with strncpy, >> although it's not exactly the same. If we want to use the former, strlcpy's >> source code should be included. >> - uint8_t, uint32_t, etc. not found. I just added stdint.h to >> binary_protocol_accelerated.c > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
-- Jérémie 'ahFeel' BORDIER
