[
https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695593#action_12695593
]
Bryan Duxbury commented on THRIFT-276:
--------------------------------------
With v6, rake spec returns
{code}
/usr/local/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:27:in
`gem_original_require': no such file to load -- thrift/serializer/serializer
(LoadError)
from /usr/local/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:27:in
`require'
from ./spec/../lib/thrift.rb:30
from /usr/local/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:27:in
`gem_original_require'
from /usr/local/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:27:in
`require'
from ./spec/spec_helper.rb:31
from ./spec/base_protocol_spec.rb:20:in `require'
from ./spec/base_protocol_spec.rb:20
from
/usr/local/lib/ruby/gems/1.8/gems/rspec-1.1.4/lib/spec/runner/example_group_runner.rb:14:in
`load'
from
/usr/local/lib/ruby/gems/1.8/gems/rspec-1.1.4/lib/spec/runner/example_group_runner.rb:14:in
`load_files'
from
/usr/local/lib/ruby/gems/1.8/gems/rspec-1.1.4/lib/spec/runner/example_group_runner.rb:13:in
`each'
from
/usr/local/lib/ruby/gems/1.8/gems/rspec-1.1.4/lib/spec/runner/example_group_runner.rb:13:in
`load_files'
from
/usr/local/lib/ruby/gems/1.8/gems/rspec-1.1.4/lib/spec/runner/options.rb:98:in
`run_examples'
from
/usr/local/lib/ruby/gems/1.8/gems/rspec-1.1.4/lib/spec/runner/command_line.rb:19:in
`run'
from /usr/local/lib/ruby/gems/1.8/gems/rspec-1.1.4/bin/spec:4
rake aborted!
{code}
Looks like you forgot to add the serializer dir to the patch.
Other than this omission, things look great.
> Ruby libraries should have one class per file
> ---------------------------------------------
>
> Key: THRIFT-276
> URL: https://issues.apache.org/jira/browse/THRIFT-276
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Affects Versions: 0.1
> Reporter: Bryan Duxbury
> Assignee: Michael Stockton
> Priority: Trivial
> Fix For: 0.1
>
> Attachments: thrift-276-v2.patch, thrift-276-v3.patch,
> thrift-276-v4.patch, thrift-276-v5.patch, thrift-276-v6.patch,
> thrift-276.patch
>
>
> There's no reason for so many of our classes to be lumped into the same file.
> For instance, transport.rb contains 9 classes. They may be short, but
> organizationally, it's superior to have separate class files. Of course, some
> files may contain more than one class per file as appropriate - things like a
> protocol and its factory, for instance, are perfectly acceptable to group.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
