[
https://issues.apache.org/jira/browse/THRIFT-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695529#action_12695529
]
Michael Stockton commented on THRIFT-276:
-----------------------------------------
I was cognizant of the bug you fixed in binary_protocol_accelerated.c -- sorry
I missed it. I made the following changes in v6:
o moved BaseServerTransport to its own file.
o migrated all require statements to thrift.rb.
o separated Serializer and Deserializer into different files.
o removed transport.rb, protocol.rb and serializer.rb.
o renamed socket_transport_spec to socket_spec.
o created server_socket_spec file.
o renamed transport_spec and protocol_spec with 'base_' prefix.
> Ruby libraries should have one class per file
> ---------------------------------------------
>
> Key: THRIFT-276
> URL: https://issues.apache.org/jira/browse/THRIFT-276
> Project: Thrift
> Issue Type: Improvement
> Components: Library (Ruby)
> Affects Versions: 0.1
> Reporter: Bryan Duxbury
> Assignee: Michael Stockton
> Priority: Trivial
> Fix For: 0.1
>
> Attachments: thrift-276-v2.patch, thrift-276-v3.patch,
> thrift-276-v4.patch, thrift-276-v5.patch, thrift-276.patch
>
>
> There's no reason for so many of our classes to be lumped into the same file.
> For instance, transport.rb contains 9 classes. They may be short, but
> organizationally, it's superior to have separate class files. Of course, some
> files may contain more than one class per file as appropriate - things like a
> protocol and its factory, for instance, are perfectly acceptable to group.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
