----- Original Message ----

> From: David Reiss <dre...@facebook.com>
> To: "thrift-dev@incubator.apache.org" <thrift-dev@incubator.apache.org>
> Sent: Sun, June 6, 2010 12:00:27 AM
> Subject: Re: Fwd: Thrift 0.3.0 RC4

> The tarball is generated from "make dist" (after bootstrap 
> and configure).

>> The key differences are the presence of 
>> thrift*.cc and thrifty.h in
>> compiler/cpp,
>> The stuff in 
>> compiler/cpp is probably the result of running make in
>> there and not 
>> cleaning up those files somehow,

> "make dist" includes all generated code in 
> the release tarball so that users don't need the yacc or lex tools to build 
> Thrift.  thrift[ly].* are generated by yacc and lex.

Did you have to teach make dist to do that or does the
standard autotool chain do this for you?

>> and the 
>> delta around client.sh in tutorial/erl.  but the
> 
>> tutorial/erl/client.sh delta is even stranger.  It should probably 
>> be
>> a symlink to tutorial/erl/server.sh but isn't for whatever 
>> reason.

"make dist" resolves all symlinks.  We should really just 
 eliminate the symlink from the repo since it adds needless 
 complexity.

Thanks for the info.  Once I am able to validate the signature
I should be able to cast a +1 for release.


      

Reply via email to