Bryan - thanks for doing this - it looks like it was a lot of work!
I have looked through this to the best of my abilities - principally by
comparing against version 0.2.0.
I apologise for my delay in doing so.
Here's some things I notice:
* there are no release notes relating to this release in the NEWS
file. In fact, the notes about 0.2.0 have gone. It seems that the
0.2.0 release notes were generated from Jira, which makes sense.
* I presume these files have no license header because they are
auto-generated?
compiler/cpp/thriftl.cc
compiler/cpp/thrifty.cc
compiler/cpp/thrifty.h
compiler/cpp/version.h.in
* Again, these file lacks a header, but don't look autogenerated:
lib/java/src/org/apache/thrift/transport: TMemoryInputTransport.java
lib/java/test/org/apache/thrift/TestStruct.java
lib/java/test/org/apache/thrift/TestTBaseHelper.java
lib/java/test/org/apache/thrift/TestTUnion.java
lib/java/test/org/apache/thrift/transport/TestTMemoryInputTransport.java
lib/js/test/src/test/TestHandler.java
lib/py/src/TSerialization.py
I'm close to giving a +1, but want to hear what you make of the above
first.
Upayavira
On Fri, 2010-06-04 at 15:57 -0700, Bryan Duxbury wrote:
> Any incubator PMC members feel like voting?
>
> ---------- Forwarded message ----------
> From: Bryan Duxbury <br...@rapleaf.com>
> Date: Tue, May 25, 2010 at 4:06 PM
> Subject: Re: Thrift 0.3.0 RC4
> To: thrift-u...@incubator.apache.org
>
>
> OK, I've seen 5 +1 votes, including 3 from committers (Mark, Jake, and
> David), and no -1 votes. It would seem to me that the vote passes.
>
> Do we need to get "official" votes from our mentors or anything, or can I
> post it?
>
> -Bryan
>
> 2010/5/25 Bjørn Borud <bbo...@gmail.com>
>
> +1
> >
> > On Tue, May 25, 2010 at 6:36 PM, Bryan Duxbury <br...@rapleaf.com> wrote:
> >
> > > Does anyone else want to vote on this release? I haven't seen any
> > > complaints
> > > yet, and I'd love to make it final.
> > >
> > > -Bryan
> > >
> > > On Wed, May 19, 2010 at 9:52 AM, Bryan Duxbury <br...@rapleaf.com>
> > wrote:
> > >
> > > > I propose that we accept:
> > > > http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc4.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc4.tar.gz>
> > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc4.tar.gz>
> > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc4.tar.gz>
> > > >
> > > > as the official Thrift 0.3.0 release. It is based on a fresh checkout
> > > from
> > > > https://svn.apache.org/repos/asf/incubator/thrift/branches/0.3.0.
> > > >
> > > > (This version includes the fixes to the erlang build that David
> > requested
> > > > be included.)
> > > >
> > > > The GPG signature can be found at
> > > > http://people.apache.org/~bryanduxbury/thrift-0.3.0-rc4.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc4.tar.gz.asc>
> > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc4.tar.gz.asc>
> > > <http://people.apache.org/%7Ebryanduxbury/thrift-0.3.0-rc4.tar.gz.asc>
> > > > with an MD5 sum of 4bb0c36a686a10d0b49734392c11a4a4
> > > >
> > > > Please download and untar, verify the signature and sum, then run
> > > configure
> > > > and make.
> > > >
> > >
> >
> >
> >
> > --
> > Bjørn Borud <bbo...@gmail.com>
> > +47 920 46465
> >
