[
https://issues.apache.org/jira/browse/THRIFT-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893803#action_12893803
]
Roger Meier commented on THRIFT-815:
------------------------------------
Thanks Jake, for applying the QUnit based test.html and the bugfixes. I
appreciate that very much!
>From my perspective, Lists and Sets with Basetypes are fixed!
But I still have issues with other Types (Map, MapMap and testInsanity from
ThriftTest.thrift):
see http://www.bufferoverflow.ch/thrift/test/test.html (r980253)
and http://www.bufferoverflow.ch/thrift/test/test_roger.html with more unit
tests.
I'm using TestServer.cpp in combination with THttpServer.cpp
> Deserialization of lists is critically broken.
> ----------------------------------------------
>
> Key: THRIFT-815
> URL: https://issues.apache.org/jira/browse/THRIFT-815
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (JavaScript)
> Affects Versions: 0.4
> Reporter: Jordan
> Assignee: T Jake Luciani
> Priority: Critical
> Fix For: 0.4
>
> Attachments: 813-1.patch, test.html, THRIFT-815_thrift.js.patch
>
>
> Edit the test code that comes with the js language target:
> var list = [1,2,3];
> var ret = client.testList(list);
> debugger;
> ret comes back as [3,3,3] when it should be echoed back as [1,2,3]
> The test case never caught this because it only verified the size, and not
> the contents of the returned array.
> I cannot find an immediate workaround, but I will try wrapping it in a dummy
> type like ListServiceResponse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
