[
https://issues.apache.org/jira/browse/THRIFT-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895887#action_12895887
]
T Jake Luciani commented on THRIFT-815:
---------------------------------------
Ah, I see, all the tests pass in Chrome (which I use) I checked in Safari and
FF and test Insanity is now failing for me.
Let me take a look and get it fixed. I'll also take a look at the c++ server.
However If it passes with java server I'd consider this particular issue
resolved.
We can open a new one for C++ issues.
Also, I don't agree with the idea of implementing the json protocol with string
parsing, js engines are very good at marshaling json its going to be much more
efficient doing it this way IMO.
> Deserialization of lists is critically broken.
> ----------------------------------------------
>
> Key: THRIFT-815
> URL: https://issues.apache.org/jira/browse/THRIFT-815
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (JavaScript)
> Affects Versions: 0.4
> Reporter: Jordan
> Assignee: T Jake Luciani
> Priority: Blocker
> Fix For: 0.4
>
> Attachments: 813-1.patch, test.html, THRIFT-815_thrift.js.patch
>
>
> Edit the test code that comes with the js language target:
> var list = [1,2,3];
> var ret = client.testList(list);
> debugger;
> ret comes back as [3,3,3] when it should be echoed back as [1,2,3]
> The test case never caught this because it only verified the size, and not
> the contents of the returned array.
> I cannot find an immediate workaround, but I will try wrapping it in a dummy
> type like ListServiceResponse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
