If I read it correctly, the effect of this patch is that the configure will fail on stock OSX 10.6.4. (That's what I have - no special Perl modules installed) Is that correct?
I don't use Perl any more, so don't know what you get in a standard Perl installation. If Bit::Vector isn't included, then I would tend to classify this more as a bug in the tests and I wouldn't make the config fail if it's not there. But possibly this is specific to OSX? - Rush On Aug 13, 2010, at 3:00 PM, Michael Lum wrote: > It's complaining about Bit::Vector not being there. I'm not sure if its > required by the Thrift library itself, or just the tests, but one way to > address it would be this patch, which checks for Bit::Vector at configure > time. > > --- configure.ac.orig 2010-08-13 14:31:33.000000000 -0700 > +++ configure.ac 2010-08-13 14:58:56.000000000 -0700 > @@ -118,6 +118,9 @@ > AX_THRIFT_LIB(perl, [Perl], yes) > if test "$with_perl" = "yes"; then > AC_PATH_PROG([PERL], [perl]) > + if test -n "`$PERL -MBit::Vector -e exit 2>&1`"; then > + AC_MSG_ERROR([Perl module Bit::Vector not installed]) > + fi > fi > AM_CONDITIONAL(WITH_PERL, [test -n "$PERL"]) > > > > On 8/13/2010 1:34 PM, Rush Manbert wrote: >> On Aug 12, 2010, at 9:40 PM, Bryan Duxbury wrote: >> >>> Hi all, >>> >>> As discussed, in all the time it took for us to finally release Thrift 0.3, >>> we've accumulated enough changes for Thrift 0.4! >>> >>> I propose we accept >>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as >>> the official Thrift 0.4.0 release. >>> >> <snip> >> >> I used the tarball on Mac OS X 10.6.4, Xcode 3.2.2, boost 1.42, zlib 1.2.3. >> >> configures fine. >> >> make completes successfully. >> >> make check errors like so: >> Making check in perl >> Making check in test >> make check-local >> ../../../compiler/cpp/thrift --gen perl ../../../test/ThriftTest.thrift >> make -f Makefile-perl.mk >> find blib -name 'Makefile*' -exec rm -f {} \; >> make check-local >> /opt/local/bin/perl -Iblib/lib >> -I/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl -I./test/gen-perl \ >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test.pl >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/*.t >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....Can't >> locate Bit/Vector.pm in @INC (@INC contains: blib/lib >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl >> /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl >> /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/vendor_perl/5.8.9 >> /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl >> /opt/local/lib/perl5/5.8.9/darwin-2level >> /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . >> /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl >> /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl >> /opt/local/lib/perl5/5.8.9/darwin-2level /opt/ > local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31. >> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line >> 31. >> Compilation failed in require at >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line >> 27. >> BEGIN failed--compilation aborted at >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line >> 27. >> # Looks like your test died before it could output anything. >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....dubious >> Test returned status 255 (wstat 65280, 0xff00) >> DIED. FAILED tests 1-6 >> Failed 6/6 tests, 0.00% okay >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........Can't >> locate Bit/Vector.pm in @INC (@INC contains: blib/lib >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl >> /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl >> /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/vendor_perl/5.8.9 >> /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl >> /opt/local/lib/perl5/5.8.9/darwin-2level >> /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . >> /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl >> /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level >> /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl >> /opt/local/lib/perl5/5.8.9/darwin-2level /opt/ > local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31. >> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line >> 31. >> Compilation failed in require at >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26. >> BEGIN failed--compilation aborted at >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26. >> # Looks like your test died before it could output anything. >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........dubious >> Test returned status 255 (wstat 65280, 0xff00) >> DIED. FAILED tests 1-2 >> Failed 2/2 tests, 0.00% okay >> Failed Test Stat Wstat Total Fail List of >> Failed >> ------------------------------------------------------------------------------- >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 6 12 1-6 >> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 2 4 1-2 >> Failed 2/2 test scripts. 8/8 subtests failed. >> Files=2, Tests=8, 1 wallclock secs ( 0.05 cusr + 0.02 csys = 0.07 CPU) >> Failed 2/2 test programs. 8/8 subtests failed. >> make[4]: *** [check-local] Error 255 >> make[3]: *** [check-am] Error 2 >> make[2]: *** [check-recursive] Error 1 >> make[1]: *** [check-recursive] Error 1 >> make: *** [check-recursive] Error 1 >> >> So I guess it's a -1 from me. >> >> - Rush
smime.p7s
Description: S/MIME cryptographic signature
