+1 from me. But I had the same issues with make check and BOOST_LDFLAGS, worked after fix test/Makefile.am.
On Thu, Aug 12, 2010 at 11:57 PM, Michael Lum <michael....@openx.org> wrote: > Works fine on CentOS 5.5. On Snow Leopard, make check was returning this: > > libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o > UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o -Wl,-bind_at_load > ./.libs/libtestgencpp.a > /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib > -lboost_unit_test_framework -lpthread > ld: library not found for -lboost_unit_test_framework > collect2: ld returned 1 exit status > make[2]: *** [UnitTests] Error 1 > make[1]: *** [check-am] Error 2 > make: *** [check-recursive] Error 1 > > I have boost-1.42.0 installed using MacPorts in /opt/local. Changing the > Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this test to > pass. All other tests passed. > > --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700 > +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700 > @@ -68,7 +68,7 @@ > TMemoryBufferTest.cpp \ > TBufferBaseTest.cpp > > -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework > +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS) > -lboost_unit_test_framework > > # > # TFDTransportTest > > Otherwise, +1. > > On 8/12/2010 9:40 PM, Bryan Duxbury wrote: >> >> Hi all, >> >> As discussed, in all the time it took for us to finally release Thrift >> 0.3, >> we've accumulated enough changes for Thrift 0.4! >> >> I propose we accept >> >> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as >> the official Thrift 0.4.0 release. >> >> I created this tarball by checking out URL: >> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and >> running >> "./bootstrap.sh&& ./configure&& make dist". >> >> The GPG signature for this tarball can be found at >> >> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>. >> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc. >> >> Please download, verify the signatures, untar, and install and test the >> libraries you are familiar with. We need your +1 votes to make the >> release! >> If you encounter any problems, please let me know immediately. This vote >> will close 72 hours from now. >> >> This release consists of 45 tickets that cover many bugs and performance >> improvements. Please refer to the CHANGES file for the full list. >> >> -Bryan >> > -- Igor Ribeiro de Assis
