[ 
https://issues.apache.org/jira/browse/THRIFT-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898770#action_12898770
 ] 

Jeff DeCew commented on THRIFT-849:
-----------------------------------

I have a hard time deciding which would be better.  Certainly there is a lot of 
information that can be inferred from order of types (given that Thrift does 
have significant restrictions based on struct and service order), and it is 
"wrong" to alphabetize a ToC, but naming conventions are often based on 
alphabetical ordering.

I tentatively +1 this patch as I think it emphasizes that ordering is relevant 
in Thrift, which is something the intended audience of HTML output may need 
reminding of.

> HTML Generator: sorting of Services and Data Types is wrong within TOC
> ----------------------------------------------------------------------
>
>                 Key: THRIFT-849
>                 URL: https://issues.apache.org/jira/browse/THRIFT-849
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.1, 0.2, 0.3
>            Reporter: Roger Meier
>            Priority: Minor
>         Attachments: 
> THRIFT-849_Services_Datatypes_Order__Datatypes_with_Key.patch
>
>
> Sorting of Services and Data Types is alphabetic, instead of the order 
> defined in thrift IDL file.
> In addidtion this patch adds the Key attribute to the Data Types Tables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to