[
https://issues.apache.org/jira/browse/THRIFT-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915415#action_12915415
]
Anthony Molinaro edited comment on THRIFT-918 at 9/27/10 2:33 PM:
------------------------------------------------------------------
Christian, I think there is something wrong with your patch, it seems to
contain differences for files which do not exist
{noquote}
patch -p0 < ~/Downloads/v4-thrift-fix-haskell-tests.patch
patching file test/ConstantsDemo.thrift
patching file test/hs/Server.hs
can't find file to patch at input line 92
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: test/hs/ThriftTest_TestServer.hs
|===================================================================
|--- test/hs/ThriftTest_TestServer.hs (revision 1000559)
|+++ test/hs/ThriftTest_TestServer.hs (working copy)
--------------------------
File to patch:
{noquote}
was (Author: djnym):
Christian, I think there is something wrong with your patch, it seems to
contain differences for files which do not exist
{quote}
patch -p0 < ~/Downloads/v4-thrift-fix-haskell-tests.patch
patching file test/ConstantsDemo.thrift
patching file test/hs/Server.hs
can't find file to patch at input line 92
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: test/hs/ThriftTest_TestServer.hs
|===================================================================
|--- test/hs/ThriftTest_TestServer.hs (revision 1000559)
|+++ test/hs/ThriftTest_TestServer.hs (working copy)
--------------------------
File to patch:
{quote}
> Make haskell tests run again
> ----------------------------
>
> Key: THRIFT-918
> URL: https://issues.apache.org/jira/browse/THRIFT-918
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Compiler, Haskell - Library
> Affects Versions: 0.5
> Environment: Mac OS X 10.6 ; GHC 6.12.3 ; Haskell Platform 2010.2.0.0
> Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010;
> root:xnu-1504.7.4~1/RELEASE_I386 i386
> The Glorious Glasgow Haskell Compilation System, version 6.12.3
> Reporter: Christian Lavoie
> Assignee: Anthony Molinaro
> Fix For: 0.5
>
> Attachments: v1-thrift-fix-haskell-tests.patch,
> v2-thrift-fix-haskell-tests.patch, v3-thrift-fix-haskell-tests.patch,
> v4-thrift-fix-haskell-tests.patch
>
>
> This allows the haskell tests to run:
> {noformat}
> cd $THRIFT/test/hs
> sh runserver.hs
> # In another terminal
> cd $THRIFT/test/hs
> sh runclient.hs
> {noformat}
> It's not awesome yet, but allows upstream to test both the library code and
> the generated code from my patches. This patch also includes a few simple
> bug/typo fixes in code I hadn't tested yet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
