[
https://issues.apache.org/jira/browse/THRIFT-918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anthony Molinaro resolved THRIFT-918.
-------------------------------------
Assignee: Christian Lavoie (was: Anthony Molinaro)
Resolution: Fixed
This applied cleanly. I was unable to actually run the tests, as they asked
for THRIFT_BIN and then when I ran with
% THRIFT_BIN=../../compiler/cpp/thrift sh runserver.sh
Missing thrift file ../../test/.thrift
So looks like there might still need to be some work to get these easier to run
(it may just be that I don't know how to run them, I tried to just do what you
suggested Christian, but is there a compile step I'm missing, and or do I have
to install first). It would be cool if they somehow ran during 'make check'
and didn't require installation of anything, but that seems like another
ticket. For now, this doesn't break anything and seems like a good addition
for 0.5 so
committing.
Christian, if you feel like taking on getting this called from 'make check'
please add a ticket and do so. Thanks for all the patches!
> Make haskell tests run again
> ----------------------------
>
> Key: THRIFT-918
> URL: https://issues.apache.org/jira/browse/THRIFT-918
> Project: Thrift
> Issue Type: Bug
> Components: Haskell - Compiler, Haskell - Library
> Affects Versions: 0.5
> Environment: Mac OS X 10.6 ; GHC 6.12.3 ; Haskell Platform 2010.2.0.0
> Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010;
> root:xnu-1504.7.4~1/RELEASE_I386 i386
> The Glorious Glasgow Haskell Compilation System, version 6.12.3
> Reporter: Christian Lavoie
> Assignee: Christian Lavoie
> Fix For: 0.5
>
> Attachments: v1-thrift-fix-haskell-tests.patch,
> v2-thrift-fix-haskell-tests.patch, v3-thrift-fix-haskell-tests.patch,
> v4-thrift-fix-haskell-tests.patch, v5-thrift-fix-haskell-tests.patch
>
>
> This allows the haskell tests to run:
> {noformat}
> cd $THRIFT/test/hs
> sh runserver.hs
> # In another terminal
> cd $THRIFT/test/hs
> sh runclient.hs
> {noformat}
> It's not awesome yet, but allows upstream to test both the library code and
> the generated code from my patches. This patch also includes a few simple
> bug/typo fixes in code I hadn't tested yet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
