#5938: assertTags fails when testing for presence of empty property
---------------------------+------------------------------------------------
Reporter: freenity | Owner:
Type: Bug | Status: reopened
Priority: High | Milestone: 1.2.x.x
Component: Test Suite | Version: 1.2 Final
Severity: Major | Resolution:
Keywords: | Php_version: n/a
Cake_version: |
---------------------------+------------------------------------------------
Changes (by freenity):
* status: closed => reopened
* resolution: invalid =>
Comment:
>Why should both tests pass? I think you need to explicitly declare the
attribute / value pairs. I see no reason why you should be able to leave
one half empty, that breaks the convention of attribute=value pairings.
When you test for presence of a tag you should be able to drop it's value.
In some use cases the attribute can be empty string or not. The convention
f attribute=value pairing is still fine as the attribute is assigned empty
string. empty=""
>Furthermore, there is no reason to wrap an assertTags() with assertTrue()
This usage is not anywhere in the core tests nor is it mentioned in the
API. Please check your usage of assertTags() as well :)
You probably have never looked at cake_test_case.test.php, that's how
assertTags() should be tested.
--
Ticket URL: <https://trac.cakephp.org/ticket/5938#comment:2>
CakePHP : The Rapid Development Framework for PHP <https://trac.cakephp.org/>
Cake is a rapid development framework for PHP which uses commonly known design
patterns like ActiveRecord, Association Data Mapping, Front Controller and MVC.
Our primary goal is to provide a structured framework that enables PHP users at
all levels to rapidly develop robust web applications, without any loss to
flexibility.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"tickets cakephp" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/tickets-cakephp?hl=en
-~----------~----~----~----~------~----~------~--~---
