#635: Fail on stop & start net/lo
----------------------------------------------------+-----------------------
Reporter: Unbeliever | Owner:
Type: defect | Status: new
Priority: normal | Milestone:
Component: Bugs in initng-ifiles | Version:
initng-ifiles-0.0.5
Severity: critical | Resolution:
Keywords: net/lo SERVICE_FAIL_START_RCODE ngc -d |
----------------------------------------------------+-----------------------
Changes (by [EMAIL PROTECTED]):
* severity: minor => critical
* version: initng-ifiles-0.0.3.2 => initng-ifiles-0.0.5
Comment:
This defect is due to this change: http://www.initng.org/changeset/3914
In initng_simple_launcher.c:simple_run
Get the command string: exec = get_string_var(&EXEC, process->pt->name,
service);
Fix variables: exec_fixed = fix_variables(exec, service);
But if there were no variables to be substitued, exec_fixed = exec
Split the args up so they can be passed to execve: argv =
split_delim(exec_fixed, WHITESPACE, &argc, 0);
We have just written '\0' into the whitespace of the original command
string.
The symptom of this is: when you restart a daemon or service a second time
it will complain, as the base command complains when it is not passed any
arguments, eg: " /sbin/ifup: Use --help for help" in the parent post.
I feel the fix needs to be made here:
In the routine: initng_env_variable.c:fix_variable
It should duplicate the string under all circumstances. Conceptually,
the act of parsing the string for variables is altering it, in zero or
more places (zero in the case of net/lo for the parent poster, and
daemon/agetty for me).
I am working on a fix, and will post once it is tested.
--
Ticket URL: <http://www.initng.org/ticket/635>
InitNG <http://www.initng.org/>
The Next Generation InitSystem_______________________________________________
Tickets mailing list
[email protected]
http://jw.dyndns.org/mailman/listinfo/tickets
