Hi Alex,

1) instead of:

temp.length+=1;
temp[temp.length-1]=a[i];


why not just...

temp.push(a[i]);

?


2) tiddlywiki has a native contains function used like this:

arr.contains(el);

so....

if(!contains(temp, a[i])){...

could just be...

if(!temp.contains(a[i])){...



3) why not use pushUnique to begin with and don't do any of that
uniqueArr() business to begin with...

all.pushUnique(list2);

?


4) However, if list2 actually is an array itself (haven't looked at it
that close)... you know that you'd be rather creating a subarray
within your 'all' array instead of adding individual items, right?


Tobias.

--

You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/tiddlywiki?hl=en.


Reply via email to