On Wednesday, June 17, 2020 at 11:07:50 AM UTC+2, TiddlyTweeter wrote: > Now for* Tiddler 2* CONTENT > > <h3>Test Level 3 Header In HTML</h3> > > ... RENDER is INcorrect, with excess <P>s > > <div class="tc-tiddler-body tc-reveal"> > <p><h3>Test Level 3 Header In HTML</h3></p> > </div> > > It is confusing & can create layout issues?? >
You are absolutely right. Not only does it create layout problems, it also creates html-code, that is "out of" html spec. (This isn't a real problem for most users, since browsers are very forgiving rendering "spec violations"). Eg: a paragrph <p> tag "should" only contain "phrasing content <https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_categories#Phrasing_content>". As you can see: headings <h> are _no_ phrasing content. Paragraphs are phrasing content. ... They should not even contain <p> childs. As you found out this can cause all sorts of problems. Theming isn't the most problematic. There are others too. There is a PR at github: Improve p generation <https://github.com/Jermolene/TiddlyWiki5/pull/4290>. from githubuser: nilslindeman, which seems to have done a "deep dive" into exactly this problem, we introduced with the TW wikitext-parser. In the PR Nils discusses the problems the existing behaviour creates and a possible solution. In a response from Oct. 2019 Jeremy wrote <https://github.com/Jermolene/TiddlyWiki5/pull/4290#issuecomment-538729125>: One of the problems in this area is that any improvements will inevitably > break backwards compatibility, because that's rather the point: this is a > situation where we explicitly want to change the current behaviour. > The important point for me here is: "*this is a situation where we explicitly want to change the current behaviour*". ... But ... There still is TWs "backwards compatibility" paradigm, which is mentioned in the same sentence. The GH discussion also mentions Arlen's PR <https://github.com/Jermolene/TiddlyWiki5/pull/4285>, which did have a different "take" and didn't get far enough for Nils. As you can see, the PR is stalled since Nov.2019... I think the main reason is, that Nils is OK with his own branch. (That's my personal guess only) There is the "last" statement from Nils: https://github.com/Jermolene/TiddlyWiki5/pull/4290#issuecomment-546708220 which (for me) point out, that the whole thing wouldn't hurt backwards compatibility. It will fix the bugs. We would need to compare the "static" output created with TW node version and the output created by Nils's feature branch. ... So we can see the differences. IMO the PR is stalled, because nobody bumped it since then. ... So you may be the one? have fun! mario -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/0172dbf8-a4ab-4907-a8c6-bd49d1bd8ae8o%40googlegroups.com.
