@bimlas I wrote a longer reply but GG crashed and did not send it.
In short: its *very* good that you reported this and such issues should be
highlighted with new releases to help people make the necessary changes.
However, personally, I would not consider this a breaking change or a
backwards compatibility issue. When a core template changes and we have
been re-using it for custom purposes, it should be expected to have to
adapt.
As long as search results tiddlers that are written from scratch work well
- that is without transcluding core templates - I think this is change
acceptable. However that suggests that we need to test this aspect.
Just to clarify, this change in the search results template was necessary
to enable the keyboard navigation of search results.
Cheers,
Saq
On Thursday, December 3, 2020 at 3:49:21 PM UTC+1 bimlas wrote:
> *A breaking change seems to have emerged*: The attached tiddler contains
> a *custom search results tab* which, in addition to normal results, also
> displayed missing tiddlers and buttons to create new tiddlers based on the
> search text. It worked correctly in 5.1.22, no longer in 5.1.23. Look for
> the word "Git" on TW.com: in 5.1.23 it only lists missing tiddlers, not
> normal results.
>
> The problem is that I transclude the default search results tiddler into
> the current one, but the macro in it refers to the fields, which doesn't
> work because of transclude. So I had to expand transclude in my search
> results.
>
> Works in 5.1.22:
>
> ...
> {{$:/core/ui/DefaultSearchResultList}}
>
> Modification for 5.1.23:
>
> ...
> <$vars configTiddler="$:/core/ui/DefaultSearchResultList">
> {{$:/core/ui/DefaultSearchResultList}}
> </$vars>
>
> Although the problem was easily resolved in my case, it is a backward
> incompatible modification, which is why I indicate it.
>
--
You received this message because you are subscribed to the Google Groups
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/tiddlywiki/d8bdb212-c846-47ab-8919-f46f214745can%40googlegroups.com.
