@Mark S

I posted some details in the issue I created for 
this: https://github.com/Jermolene/TiddlyWiki5/issues/5317

The text you see is from the default attribute of the <$edit-text> in the 
UI, see 
https://github.com/Jermolene/TiddlyWiki5/blob/master/core/ui/ControlPanel/Saving/GitHub.tid#L13

When the underlying tiddler does not exist:
- the UI shows the branch as "master".
- the code after the recent changes, uses "main" instead.

On Thursday, December 24, 2020 at 8:46:39 PM UTC+1 Mark S. wrote:

> I don't understand. My branch was specified (it shows as "master" in the 
> saver panel). But I had to delete it and type it in again to get it to 
> work. So is there an internal 5.1.23 configuration file that has to be 
> overwritten?
>
> Thanks! 
>
> On Thursday, December 24, 2020 at 11:37:56 AM UTC-8 [email protected] 
> wrote:
>
>> Yep, we have our first bug. The placeholder shown when the branch has not 
>> been specified is "master", but the code uses "main" for the branch.
>>
>> The interim fix for users is fortunately easy, just empty and re-fill the 
>> branch name.
>>
>> On Thursday, December 24, 2020 at 8:33:15 PM UTC+1 Saq Imtiaz wrote:
>>
>>> Hmm. I am a bit surprised that worked. I wonder if the changes made to 
>>> the Github saver to reflect the change made by Github to the default 
>>> branch  (master vs main) got something wrong.
>>>
>>> On Thursday, December 24, 2020 at 8:30:50 PM UTC+1 Ste wrote:
>>>
>>>> Cheers Saq! 
>>>> Refilled in all fields and for some reason.. It works..! 
>>>>
>>>>
>>>> On Thursday, 24 December 2020 at 19:25:22 UTC Ste wrote:
>>>>
>>>>> Just reread my own post.. Let me clarify... Using the git hub saving 
>>>>> in tiddlywiki works in pre release but not from newly upgraded. This is 
>>>>> true both with the file on my phone or the new file uploaded to git hub 
>>>>> and 
>>>>> trying the github saver from there. 
>>>>> XMLHttpRequest error code: 401
>>>>> Sorry. It's a 401. Not a 404.. I'm losing the plot.. Mulled wine time! 
>>>>>
>>>>> On Thursday, 24 December 2020 at 19:10:55 UTC Ste wrote:
>>>>>
>>>>>> I'm sure it's my own muppetry and that I'm trying to do this on my 
>>>>>> phone but, I can succesfully upload pre upgrade wiki but not post 
>>>>>> upgrade 
>>>>>> wiki to github using the git hub saving mechanism. I am getting a 404 
>>>>>> error. Any one else finding this?
>>>>>
>>>>>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/20bd02ba-dc43-49a6-8487-2410e2023928n%40googlegroups.com.

Reply via email to