Hi wjam This is looking good, congratulations. As discussed above, we need to figure out how to reconcile this with the PR I’ve been working on (https://github.com/Jermolene/TiddlyWiki5/pull/3112 <https://github.com/Jermolene/TiddlyWiki5/pull/3112>):
The first thing to note is that your version has many more more features. That’s great, but I’m also mindful of the discussion we’ve been having about whether diffing should go into the core (https://groups.google.com/d/topic/tiddlywiki/tqVmYrWCXf0/discussion <https://groups.google.com/d/topic/tiddlywiki/tqVmYrWCXf0/discussion>). I believe that we should put it in the core for the reasons I’ve given elsewhere (because it is of universal utility, and to enable further development using the same library). However, because of concern about bloat I think only the most essential UI functions should go in the core). The second point is that you are using a different JS library (https://github.com/kpdecker/jsdiff <https://github.com/kpdecker/jsdiff> vs. https://github.com/google/diff-match-patch <https://github.com/google/diff-match-patch>). I’m using the latter because it’s highly regarded and I’m familiar with it. There’s also the matter that your implementation incorporates the library as a macro, rather than a widget, which causes issues with the refresh mechanism. So, I’m going to go ahead and merge #3112, and I hope we can work together to bring your additional features to the core implementation, Best wishes Jeremy. > On 11 Mar 2018, at 14:52, wjam <[email protected]> wrote: > > UPDATE > > Versions tab in the sidebar > > showing all revisions (last 80 days max 14/tiddler) > > including options to preview/compare changes, delete oldtxt, or restore > oldtxt. > > Logs tab, > > showing log tiddlers (log_YYYYMMDD) > > with time stamps when tiddlers were changed > > including options to preview & delete one of the log tiddlers > > KR > wjam... > > -- > You received this message because you are subscribed to the Google Groups > "TiddlyWiki" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > To post to this group, send email to [email protected] > <mailto:[email protected]>. > Visit this group at https://groups.google.com/group/tiddlywiki > <https://groups.google.com/group/tiddlywiki>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/tiddlywiki/321bbc18-2246-4b2b-8d36-cf812bbe9f6b%40googlegroups.com > > <https://groups.google.com/d/msgid/tiddlywiki/321bbc18-2246-4b2b-8d36-cf812bbe9f6b%40googlegroups.com?utm_medium=email&utm_source=footer>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/tiddlywiki. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/49B6AD25-5E4A-4B45-B097-15EEE2DE2214%40gmail.com. For more options, visit https://groups.google.com/d/optout.
