Hi Dave

That’s great. My first thought is that it might be nice if the comment plugin 
was themable.

I’ve no objection to changing the default styling, but I think our objectives 
might be contradictory here. I intentionally made the “add comment” button 
green, a  colour that isn’t part of the default TW5 palette, rather than 
reusing the standard “blue” primary colour, so that the comment machinery would 
stand out. I suspect that your changes are trying to stop them standing out. 
Similarly, I used a faint background colour for the comments to intentionally 
differentiate them from the tiddlers to which they are attached. So I think 
these two themes might serve different purposes.

Best wishes

Jeremy.

> On 6 Oct 2018, at 19:02, David Gifford <[email protected]> wrote:
> 
> Hi all
> 
> I tweaked the stylesheet for the Comments plugin found in the pre-release. I 
> think this look conforms more closely to the TiddlyWiki aesthetic and would 
> be a better default look. Feedback?
> 
> Also, I am not a fan of GitHub - maybe someone would like to push these 
> suggestions there?
> 
> Here are the results:
> 
> http://giffmex.org/experiments/prerelease.tweaks.html 
> <http://giffmex.org/experiments/prerelease.tweaks.html>
> 
> The two tweaked tiddlers are $:/plugins/tiddlywiki/comments/styles 
> <http://giffmex.org/experiments/prerelease.tweaks.html#%24%3A%2Fplugins%2Ftiddlywiki%2Fcomments%2Fstyles>
>  and 
> $:/plugins/tiddlywiki/comments/toolbar-button-edit 
> <http://giffmex.org/experiments/prerelease.tweaks.html#%24%3A%2Fplugins%2Ftiddlywiki%2Fcomments%2Ftoolbar-button-edit>
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWiki" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to [email protected] 
> <mailto:[email protected]>.
> To post to this group, send email to [email protected] 
> <mailto:[email protected]>.
> Visit this group at https://groups.google.com/group/tiddlywiki 
> <https://groups.google.com/group/tiddlywiki>.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywiki/ce81cf71-5802-4365-a51e-90ef545e884e%40googlegroups.com
>  
> <https://groups.google.com/d/msgid/tiddlywiki/ce81cf71-5802-4365-a51e-90ef545e884e%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout 
> <https://groups.google.com/d/optout>.

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywiki/9C931EE6-AF75-483C-9CB1-6D5C2637577D%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to