Hi Jeremy Yes I figured that those were your reasons for making the styling choices you did.
My answer: I think there is a distinction between making something stand out within a color scheme, and making something clash with that color scheme. I have made another example, this time with a more intense blue to make it pop a little more, and with shading in the background of the comments to make them more distinct. I think this might answer your concerns, while also making it look less jarring than the colors at the official prerelease. Compare http://giffmex.org/experiments/prerelease.tweaks2.html with my previous http://giffmex.org/experiments/prerelease.tweaks.html What do you think? On Sunday, October 7, 2018 at 4:22:36 AM UTC-5, Jeremy Ruston wrote: > > Hi Dave > > That’s great. My first thought is that it might be nice if the comment > plugin was themable. > > I’ve no objection to changing the default styling, but I think our > objectives might be contradictory here. I intentionally made the “add > comment” button green, a colour that isn’t part of the default TW5 > palette, rather than reusing the standard “blue” primary colour, so that > the comment machinery would stand out. I suspect that your changes are > trying to stop them standing out. Similarly, I used a faint background > colour for the comments to intentionally differentiate them from the > tiddlers to which they are attached. So I think these two themes might > serve different purposes. > > Best wishes > > Jeremy. > > On 6 Oct 2018, at 19:02, David Gifford <[email protected] <javascript:>> > wrote: > > Hi all > > I tweaked the stylesheet for the Comments plugin found in the pre-release. > I think this look conforms more closely to the TiddlyWiki aesthetic and > would be a better default look. Feedback? > > Also, I am not a fan of GitHub - maybe someone would like to push these > suggestions there? > > Here are the results: > > http://giffmex.org/experiments/prerelease.tweaks.html > > The two tweaked tiddlers are $:/plugins/tiddlywiki/comments/styles > <http://giffmex.org/experiments/prerelease.tweaks.html#%24%3A%2Fplugins%2Ftiddlywiki%2Fcomments%2Fstyles> > > and > $:/plugins/tiddlywiki/comments/toolbar-button-edit > <http://giffmex.org/experiments/prerelease.tweaks.html#%24%3A%2Fplugins%2Ftiddlywiki%2Fcomments%2Ftoolbar-button-edit> > > -- > You received this message because you are subscribed to the Google Groups > "TiddlyWiki" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > To post to this group, send email to [email protected] > <javascript:>. > Visit this group at https://groups.google.com/group/tiddlywiki. > To view this discussion on the web visit > https://groups.google.com/d/msgid/tiddlywiki/ce81cf71-5802-4365-a51e-90ef545e884e%40googlegroups.com > > <https://groups.google.com/d/msgid/tiddlywiki/ce81cf71-5802-4365-a51e-90ef545e884e%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > > > -- You received this message because you are subscribed to the Google Groups "TiddlyWiki" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/tiddlywiki. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/b0b17cff-5e82-4220-980c-04d8f05350fc%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
