I don't see why not. It might be better for the tagging macro to support filters, as you might want to sort the tags by something other than title e.g. <<tagging filter:[sort[modified]]>>
The next step would be to send a pull request to: https://github.com/tiddlywiki/tiddlywiki However, the code would not be put into the core without tests. As I understand it all valid pull requests require tests. This would mean writing tests that cover the existing code base and also tests that show the effects of your change. Jon On Jun 21, 3:11 am, Arlen Beiler <[email protected]> wrote: > Sorry for two in a row, but I should have mentioned that it goes under var > prompt = tagged.length == 0 ? this.labelNotTag : this.label; > At least that is where I put it. I don't know if there are any problems with > putting it there or not, but that looked right. I haven't thoroughly tested > it, I just know it works good. > > > > > > > > On Mon, Jun 20, 2011 at 10:07 PM, Arlen Beiler <[email protected]> wrote: > > Ok, here is the working code: > > > var sortby = getParam(params,"sortby",false); > > if(sortby&&sortby.length) { > > store.sortTiddlers(tagged,sortby); > > } > > > As you can see this uses the sortby paramater rather than a blank. > > > On Mon, Jun 20, 2011 at 7:01 PM, Arlen Beiler <[email protected]> wrote: > > >> Would it be a big deal to add support for sorting > >> to config.macros.tagging.handler? I don't know if this is all that is > >> required, but here is a code sample. > > >> var sortby = this.getAttribute("sortby"); > >> if(sortby&&sortby.length) { > >> store.sortTiddlers(tagged,sortby); > >> } > > >> How we get sortby set is not quite as obvious to me in this case since I > >> am not sure where params gets set. A pointer would be helpful. -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/tiddlywikidev?hl=en.
