"Is there more to testing than just that? Generally as part of testing a piece of test code should be written and added to:
https://github.com/TiddlyWiki/tiddlywiki/tree/master/test/js The task of writing the test code belongs to the person submitting the pull request, or making the submission to github. Ideally the user who makes a code suggestion should also write the test code, but often users don't have the experience of writing test code - in this case the task of writing the test code falls to a member of the TiddlyWiki team. Martin On 21 June 2011 12:34, Arlen Beiler <[email protected]> wrote: > The other way looks quicker, so here it is. > ul.setAttribute("title",this.tooltip.format([title])); > > var sortby = getParam(params,"sortby",false); > var tagged = store.getTaggedTiddlers(title,sortby); > var prompt = tagged.length == 0 ? this.labelNotTag : this.label; > As for testing, I tried the tag with and without sortby param with tags and > regular pages. Is there more to testing than just that? > On Tue, Jun 21, 2011 at 7:10 AM, colmjude <[email protected]> wrote: >> >> >> On Jun 21, 12:04 pm, Martin Budden <[email protected]> wrote: >> > Colm, >> > >> > why are you sorting the store, rather than passing the sortfield to >> > getTaggedTiddlers? >> >> I was just using the code provided by Arlen. >> >> > >> > Martin >> > >> > On 21 June 2011 11:55, colmjude <[email protected]> wrote: >> > >> > I don't think your code work, don't you mean: >> >> The code provided does work in tests I've performed. >> >> > var sortby = getParam(params,"sortby",false); >> > var tagged = store.getTaggedTiddlers(title,sortby); >> >> Although this would make more sense :) >> >> Colm >> >> -- >> You received this message because you are subscribed to the Google Groups >> "TiddlyWikiDev" group. >> To post to this group, send email to [email protected]. >> To unsubscribe from this group, send email to >> [email protected]. >> For more options, visit this group at >> http://groups.google.com/group/tiddlywikidev?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "TiddlyWikiDev" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/tiddlywikidev?hl=en. > -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/tiddlywikidev?hl=en.
