Hi Eskha I can't duplicate the issue you're seeing with the Rocker theme, could you very kindly step through it?
Many thanks, Jeremy On Mon, Aug 5, 2013 at 9:02 AM, Eskha <[email protected]> wrote: > Thank you Jeremy for your answer, > > Your fix for the search box solved the issue. > (By the way, when testing your code I first tried to update the shadow > tiddler §:/core/modules/filters/search.js directly inside my tiddlywiki, > which broke the search function even after a refresh ; so I reverted to > update the source file which worked). > > For the right toolbar freeze, I haven't found yet a way to replicate it. I > will try again after my holidays and keep you updated. > > For the theme issue, your temporary workaround works great for me as I use > the Blanca theme but it may have some side effect for others: for instance > the Rocker theme is perturbed by this workaround and I can't revert to a > pure Snow White theme. If you want, I can test it again when you will have > fixed the order in which stylesheets are applied. > > Thank you again for your very helpful and detailed answer. > > Best regards. > > Eskha > > > Le samedi 3 août 2013 10:42:57 UTC+2, Jeremy Ruston a écrit : >> >> Hi Eskha >> >> Apologies for the late reply - this is great feedback, much appreciated. >> >> On Mon, Jul 29, 2013 at 10:10 AM, Eskha <[email protected]> wrote: >> >>> * When using the search box to find a tiddler, for instance a tiddler >>> named 'test', I see it in the result list only until I enter the last >>> character (t, te, tes => Ok, but test failed to provide me the 'test' >>> tiddler). The result list still display results including the search >>> pattern (test1 for instance). >>> >> >> Brilliant, thank you, I hadn't noticed that. Some leftover code was >> excluding tiddlers titled with the search term from the search results. >> It's fixed here: >> >> https://github.com/Jermolene/**TiddlyWiki5/commit/** >> 799647e38bc858f3b3a548508c77f0**c867985438<https://github.com/Jermolene/TiddlyWiki5/commit/799647e38bc858f3b3a548508c77f0c867985438> >> >> >>> * Often, the right toolbar freezes on a tab (for instance the 'Tools' >>> tab). If I click on an other tab (for instance 'More') the tab appears to >>> be selected (The colours of the tab headers change) but its content remains >>> the one from the previous tab ('Tools' in this case). >>> >> >> I've also occasionally encountered this problem, but not yet been able to >> analyse it as I've been unable to replicate it. Any help there would be >> much appreciated. >> >> >>> * Themes >>> ** I use the Blanca theme. At startup, the theme is not correctly >>> applied: I see a mix of this theme and the Snow hite theme . I need to >>> click on the Snow White theme then on the Blanca theme in the Tools tab to >>> force the theme to be correctly applied. >>> >> >> This is an issue with the order in which stylesheets are applied, I'm >> working on a fix. As a workaround in the meantime, I've increased the >> specificity of the style rules in the giffmex themes: >> >> https://github.com/Jermolene/**TiddlyWiki5/commit/** >> 0e78ecd3e04b5ab9548f5c52c2091d**49fa05e649<https://github.com/Jermolene/TiddlyWiki5/commit/0e78ecd3e04b5ab9548f5c52c2091d49fa05e649> >> >> >>> ** By the way, when you click on an already selected theme in the Tools >>> tab: >>> *** 1st click: default to Snow White theme but does not change the state >>> of the displayed current theme ($:/themes/giffmex/blanca and the dot it in >>> front of the theme name) ; >>> *** 2nd click : nothing happens >>> >> >> I think that this is fixed too, let me know what you find. >> >>> >>> Hope this will help improves TiddlyWiki5. >> >> >> Yes, very helpful, thank you. It's always nice to be able to respond to a >> query with a code commit, >> >> Best wishes >> >> Jeremy >> >> >>> >>> >>> Eskha >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "TiddlyWikiDev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to tiddlywikide...@**googlegroups.com. >>> To post to this group, send email to [email protected]**. >>> >>> Visit this group at >>> http://groups.google.com/**group/tiddlywikidev<http://groups.google.com/group/tiddlywikidev> >>> . >>> For more options, visit >>> https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out> >>> . >>> >>> >>> >> >> >> >> -- >> Jeremy Ruston >> mailto:[email protected] >> > -- Jeremy Ruston mailto:[email protected] -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/tiddlywikidev. For more options, visit https://groups.google.com/groups/opt_out.
