My take: Avoid modifying (hyjacking) core code. Instead write a new class that extends the one you wanted to modify and use that. If you are attempting to change the core functionality I would recommend cloning the repo and make the change in the core code on you own branch. If it is something worth while it could be submitted as pull request maybe behind a config option.
On Monday, December 28, 2015 at 3:09:06 PM UTC-5, Tobias Beer wrote: > > Hi Jeremy, > > >> Obviously, this is a technique of last resort… >> > > I agree and I would not ask for how to do it would I see another way. > > For the appear widget (demo) <http://appear-demo.tiddlyspot.com> I have now > "properly" hijacked > <https://github.com/tobibeer/tw5-appear/blob/master/src/appear.js#L379-L425> > ... > > Popup.prototype.show = function(options) {...} > > ...so as to allow absolutely positioned popups > <https://github.com/Jermolene/TiddlyWiki5/pull/2128>. > > Best wishes, > > Tobias. > -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/tiddlywikidev. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/0d061e99-d2a5-4fb0-beed-1c598a422f40%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
