Hi Devin, > Looking at your code I would push the *hackery* as far away as possible. > Here is a stab at how I would approach the same problem > https://gist.github.com/71a1e6b22104ede5f6e7 (Google Groups just had a > tantrum attempting to copy/paste the code here. Use the link above. > (╯°□°)╯︵ ┻━┻ ). >
Thanks a lot for taking the time and provide this alternative code. I'm always keen to learn good coding practice. I very much agree that it looks much cleaner to factor all the popup stuff out into its own utils module. And, I believe I can do the very same with my codebase, as well. Other than that, though, your code basically does the same thing: overwrite the core popup handler. However, besides being encapsulated in its own module, it appears to be less efficient though, since you're not only calculating all things twice but also writing to the store twice, once the core handler and then the custom code of EnhancedPopup. Best wishes, Tobias. -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/tiddlywikidev. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/851af6b4-008e-488f-b814-c8be985c181d%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
