@Mat
Hm, since it is always matched against existing strings (e.g titles) is
> that not enough? I mean the fragment "Editox" is as disallowed as e.g
> "Edito]]" , is it not? (But I have to admit this logic of mine it feels
> like I'm stepping back to how it was when before you stepped in when I
> couldn't tell where the end of the fragment was...)
>
It was a suggestion that if you find the peformance slowdown unacceptable,
then you could replace the title matching filter in the detection code with
one that just rejects fragments with disallowed characters. It would be
faster though far less accurate.
There are other options that could be explored via refactoring to try and
get around the performance issues, but it would be a fair bit of work that
may or may not yield results.
>
>>>> - I am also unsure if we need this list anymore (after introducing
>>>> em-itemfilter):
>>>> <$list
>>>>
>>>> filter="[<em-fragment>length[]add<before-length>add<trigger-length>match<selectionEnd>]"
>>>>
>>>> variable="_NULL" emptyMessage=<<em-checkNextTrigger>>>
>>>> ...
>>>>
>>>> No discernible difference in a side by side.
>>>
>>
>> If you are sure about this, we can remove this list and the variables
>> that are there just for its sake.
>>
>
> As sure as my primitive test is, yes ;-)
>
You removed the correct list, other than that I am not sure what I should
be looking at or what has changed. Do go through all the variables declared
in body/editor and make sure that we are still actually using them.
> Are you saying filtered transclusion {{{...}}} is evaluated for each
> stroke but $list is not? That sounds like great but I also don't understand
> how that is possible since listwidgets do update when their filter
> changes.... don't they?
>
No. The attempt at paraphrasing completely looses the original meaning.
Explaining this properly would require explaining the widget tree and
refresh mechanism.. something I don't have time to get into now. Feel free
to bring it up in a separate thread at a different occasion.
However, I did say that this is only an issue if its the display code
causing the performance issues. So based on what you are reporting, I am
unsure why you are focusing on this at the moment.
Saq
--
You received this message because you are subscribed to the Google Groups
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/tiddlywikidev/9229297b-a8a0-45f4-9072-ea71808a7b07o%40googlegroups.com.
