Hi,

On the tif_win32.c change which said:
- Behavior of TIFFOpen() mode "r+" in the Windows implementation adjusted
to that of Linux.

I still see in `TIFFOpenWExt()` that we have:
```
        case O_RDWR:
            dwMode = OPEN_ALWAYS;
            break;
```
Doesn't this need to be changed to OPEN_EXISTING as well?

On reading this code now, I'm not sure that the O_TRUNC case is handled
correctly either since I don't see TRUNCATE_EXISTING being used anywhere.

Best regards,
-Edward


On Fri, Jun 9, 2023 at 9:07 AM Even Rouault <[email protected]>
wrote:

> Hi,
>
> I've prepared a release candidate for libtiff v4.5.1:
>
> - https://download.osgeo.org/libtiff/tiff-4.5.1rc1.tar.gz
> - https://download.osgeo.org/libtiff/tiff-4.5.1rc1.tar.gz.sig
> - https://download.osgeo.org/libtiff/tiff-4.5.1rc1.tar.xz
> - https://download.osgeo.org/libtiff/tiff-4.5.1rc1.tar.xz.sig
> - https://download.osgeo.org/libtiff/tiff-4.5.1rc1.zip
> - https://download.osgeo.org/libtiff/tiff-4.5.1rc1.zip.sig
>
> Release notes at https://libtiff.gitlab.io/libtiff/releases/v4.5.1.html
>
> I'll promote it to final next week if no serious blocking issues are
> reported.
>
> Thanks to all contributors.
>
> Best regards,
>
> --
> http://www.spatialys.com
> My software is free, but my time generally not.
>
> _______________________________________________
> Tiff mailing list
> [email protected]
> https://lists.osgeo.org/mailman/listinfo/tiff
>
_______________________________________________
Tiff mailing list
[email protected]
https://lists.osgeo.org/mailman/listinfo/tiff

Reply via email to