On Fri, Mar 13, 2009 at 08:55:57AM +0100, Peter Åstrand wrote: > On Thu, 12 Mar 2009, Peter Åstrand wrote: > >>>> My primary objective is to make sure Xvnc in TigerVNC can properly run >>>> KDE4. The easy solution is to simply remove >>>> "pScreen->backingStoreSupport=Always", but I'd like to know if this is >>>> the "correct" way of doing it. Of course, it will still crash if "+bs" is >>>> manually specified, just like the normal Xorg, due to the bug above. >>> >>> Do you know if KDE4 requires composite? >> >> Don't know, will test tomorrow. > > Tested now, KDE 4.2 on Fedora 9 works even if the Xserver is started with > "-extension Composite". > > To summarize, my suggestion is that we remove: > > pScreen->backingStoreSupport = Always; > > ...from xvnc.cc. This would make Xvnc behave just like the other servers. > > > Then there's the question of if we should keep or remove > miInitializeBackingStore(). I suggest that we try to stay as close as > possible to Xvfb; this means keep miInitializeBackingStore().
It's not only "as close as possible to Xvfb" reason. If I read code correctly if you don't cann miInitializeBackingStore then all backing store methods are unitialized which might end with "interesting" behavior. > > So if noone objects, I will commit this patch: Patch looks fine for me, feel free to commit it. > > Index: unix/xserver/hw/vnc/xvnc.cc > =================================================================== > --- unix/xserver/hw/vnc/xvnc.cc (revision 3663) > +++ unix/xserver/hw/vnc/xvnc.cc (arbetskopia) > @@ -1145,7 +1145,7 @@ > > if (!ret) return FALSE; > > - /* miInitializeBackingStore(pScreen); */ > + miInitializeBackingStore(pScreen); > > /* > * Circumvent the backing store that was just initialised. This amounts > @@ -1203,11 +1203,6 @@ > pvfb->closeScreen = pScreen->CloseScreen; > pScreen->CloseScreen = vfbCloseScreen; > > -#ifndef NO_INIT_BACKING_STORE > - miInitializeBackingStore(pScreen); > - pScreen->backingStoreSupport = Always; > -#endif > - > return ret; > > } /* end vfbScreenInit */ > Adam -- Adam Tkac, Red Hat, Inc. ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
