On Fri, 13 Mar 2009, Adam Tkac wrote:
Then there's the question of if we should keep or remove
miInitializeBackingStore(). I suggest that we try to stay as close as
possible to Xvfb; this means keep miInitializeBackingStore().
It's not only "as close as possible to Xvfb" reason. If I read code
correctly if you don't cann miInitializeBackingStore then all backing
store methods are unitialized which might end with "interesting"
behavior.
miInitializeBackingStore does:
pScreen->SaveDoomedAreas = NULL;
pScreen->RestoreAreas = NULL;
pScreen->ExposeCopy = NULL;
pScreen->TranslateBackingStore = NULL;
pScreen->ClearBackingStore = NULL;
pScreen->DrawGuarantee = NULL;
But these members are also initialized by miScreenInit:
pScreen->SaveDoomedAreas = 0;
pScreen->RestoreAreas = 0;
pScreen->ExposeCopy = 0;
pScreen->TranslateBackingStore = 0;
pScreen->ClearBackingStore = 0;
pScreen->DrawGuarantee = 0;
miScreenInit is called via fbScreenInit. But better safe than sorry.
So if noone objects, I will commit this patch:
Patch looks fine for me, feel free to commit it.
Great, done.
Best regards,
---
Peter Åstrand ThinLinc Chief Developer
Cendio AB http://www.cendio.com
Wallenbergs gata 4
583 30 Linköping Phone: +46-13-21 46 00
------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
