On Mon, 06 Apr 2009 04:00:21 -0500
DRC <dcomman...@users.sourceforge.net> wrote:

> 
> I first ran revision 3757 against 3759 to measure the effect of the
> colorspace enhancements.  I found the effect to be negligible (< 5%), so
> I would recommend backing off to 3757 for this release, and I can
> re-investigate those enhancements post 1.0.0.  I think part of the
> problem is that there is still a buffer copy happening in
> TransImageGetter, so this probably hides the boost due to the enhanced
> colorspaces.  After 1.0.0, one of the first mods I'll try to make is to
> compress JPEG directly out of the PixelBuffer whenever no pixel
> translation is required.
> 

The current system of giving the encoders just a TransImageGetter with
the client's PF is brain dead IMO. They should at the very least get a
pointer to both the TIG and the original PixelBuffer.

I think long term that we should break out the conversion code from
TIG, merge it with the one in PixelBuffer and have a bunch of
conversion objects available for the Encoders to use as suitable. The
connection object can recreate these as appropriate when the client PF
changes.

> 
> The performance boost due to '-deferUpdate 1' is not surprising at all.
>  Whenever Pierre enabled pipelining of the framebuffer update requests
> in the client, this created a situation identical to that of TurboVNC
> 0.3.2.  Effectively, all of the frames on the server were being
> deferred, so the performance enhancements due to the improved libjpeg
> were at least partially hidden.  Enabling '-deferUpdate 1' creates a
> situation similar to that of TurboVNC 0.4, which should be optimal on
> both high-latency and low-latency networks.
> 

Is there any point to keeping the deferred update system?

Rgds
-- 
Pierre Ossman            OpenSource-based Thin Client Technology
System Developer         Telephone: +46-13-21 46 00
Cendio AB                Web: http://www.cendio.com

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel

Reply via email to