On Fri, Nov 06, 2009 at 04:51:42PM -0800, Alan Coopersmith wrote: > I've been finishing off this week the update of the VNC packages > for OpenSolaris & Solaris "Nevada" (i.e. the development branch > of what will become the next major Solaris release at some point) > from RealVNC 4.1.3 to TigerVNC 1.0. We'd previously been > borrowing Fedora's patches to build RealVNC with current Xorg > releases, and since that's no longer an option, decided to move > to TigerVNC. > > Attached are some of the patches we're using to build at the moment, > all of which I think are ready to go upstream and hopefully will > either help, or at least not harm, other platforms as well. > > (Since I'm more familiar with git than svn, I've been using git-svn > to manage these, but I believe they should be easy to apply to svn > trees as well.)
Hi Alan, thanks for the patches, check my comments below, please. 0001-Don-t-run-configure-for-unused-subdirs.patch - I don't like it much. It will break functionality of `make dist` . This is bigger problem from my point of view than "slow" /configure 0002-Fix-detection-of-network-libraries-functions-on-So.patch - Looks fine for me. Would it be possible to test if (with this patch) x0vncserver_LDADD variable (in unix/x0vncserver/Makefile.am) has to contain @INET_LIB@, please? I think it will be removed. 0003-Fix-crash-in-TcpSocket-sameMachine-for-IPv6-connect.patch - Looks fine, will be commited. 0004-Update-Xvnc-man-page-references-from-XFree86-to-Xorg.patch - Looks fine, will be commited. 0005-Redefine-public-structure-member-to-avoid-clash-wi.patch - Looks fine, will be commited. 0006-Use-dev-urandom-for-xauth-cookie-generation.patch - Looks fine, will be commited. Regards, Adam -- Adam Tkac, Red Hat, Inc. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
