On Fri, 26 Aug 2011 20:29:17 +0200
Martin Koegler <mkoeg...@auto.tuwien.ac.at> wrote:

> On Fri, Aug 26, 2011 at 09:36:25AM +0200, Pierre Ossman wrote:
> > Looks good to me, with two notes:
> > 
> > >  vncviewer/keysyms.cxx       |   71 
> > > +++++++++++++++++++++++++++++++++++++++++++
> > >  vncviewer/keysyms.h         |   30 ++++++++++++++++++
> > 
> > Perhaps another name might be better as to not confuse this with the
> > X11/VNC keysym handling? menukey.*?
> 
> If you suggest a better name, I'll repost a changed patch.
> 

menukey.cxx/.h. That matches the function names.

> How should we proceed?
> 
> Should I send a new version of the patch? If yes, what changes/features do 
> you expect?

You seem to be providing good stuff<tm>, so I'd vote for you getting
commit rights. Adam? DRC? Any objections?

Rgds
-- 
Pierre Ossman            OpenSource-based Thin Client Technology
System Developer         Telephone: +46-13-21 46 00
Cendio AB                Web: http://www.cendio.com

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Special Offer -- Download ArcSight Logger for FREE!
Finally, a world-class log management solution at an even better 
price-free! And you'll get a free "Love Thy Logs" t-shirt when you
download Logger. Secure your free ArcSight Logger TODAY!
http://p.sf.net/sfu/arcsisghtdev2dev
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel

Reply via email to