If this is a simple bug fix, then please explain what bug it fixes. That's all I'm asking. Looking at the code, it looks to be deeper than a simple bug fix. For it to be a "bug", it must be reproducible by an end user. What I'm asking is for steps to reproduce the bug from a user's point of view so that I can reproduce the problem and peer review your solution to it.
Once software has entered the beta process, the time for fixing anything except tangible, reproducible issues is over, because fixing intangible, potential issues has a habit of creating tangible, reproducible regressions. Any large software organization (and most large OSS projects as well) would require an official bug report and analysis to precede the commit of a patch such as this. I don't think I'm being unreasonable in asking for more clarification. It's not as if this code is untested. I need an understanding of why this issue has not surfaced before now and what made it surface now. The Tight encoder/decoder have undergone many many hours of low-level testing, much of which may need to be repeated if something significant changes, and this appeared to be significant enough that it would warrant performance regression testing as well. On 2/3/12 2:10 AM, Peter Åstrand wrote: > > We are considering patch r4841 as a simple bugfix, solving a previous > regression. If it causes additional problems, please let us know. > > When it comes to the Java client, we are currently not using that one, > so I have no strong opinion. > > Rgds, > Peter > > On Thu, 2 Feb 2012, DRC wrote: > >> I hadn't actually branched 1.2 yet, so trunk is still supposed to be >> stable. I was waiting for a more reasonable explanation of 4841 from >> Pierre before branching, as that patch appears destabilizing as well. >> >> >> On 2/2/12 11:38 PM, bph...@users.sourceforge.net wrote: >>> Revision: 4842 >>> >>> http://tigervnc.svn.sourceforge.net/tigervnc/?rev=4842&view=rev >>> Author: bphinz >>> Date: 2012-02-03 05:38:23 +0000 (Fri, 03 Feb 2012) >> >> ------------------------------------------------------------------------------ >> >> Try before you buy = See our experts in action! >> The most comprehensive online learning library for Microsoft developers >> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, >> Metro Style Apps, more. Free future releases when you subscribe now! >> http://p.sf.net/sfu/learndevnow-dev2 >> _______________________________________________ >> Tigervnc-devel mailing list >> Tigervnc-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/tigervnc-devel >> > > > --- > Peter Åstrand ThinLinc Chief Developer > Cendio AB http://www.cendio.com > Wallenbergs gata 4 > 583 30 Linköping Phone: +46-13-21 46 00 > > > ------------------------------------------------------------------------------ > Try before you buy = See our experts in action! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-dev2 > > > > _______________________________________________ > Tigervnc-devel mailing list > Tigervnc-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tigervnc-devel ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
