>
> Revision: 4950
> http://tigervnc.svn.sourceforge.net/tigervnc/?rev=4950&view=rev
> Author: astrand
> Date: 2012-08-08 11:49:01 +0000 (Wed, 08 Aug 2012)
> Log Message:
> -----------
> Make it possible to load and save configuration files. Also, when
> connecting, the options are saved as default settings. This patch
> fixes SF bugs 3481470 and 3499216.
>
Hi Peter,
I haven't tried this yet, but unless I've missed something, won't it cause
the values of the global parameters to be changed when a config file is
loaded? Without a rollback mechanism, if the user then cancels the options
dialog those changes will still go into effect. I don't think that's the
behavior that most people would expect.
FWIW, I've been working on adding this functionality to the java viewer and
used an instance of an rfb::Configuration object to hold temporary values
of the parameters. That way, all of the changes made in the dialog don't
get committed until the dialog is OK'd. The global config and options
config are sync'd up via the assignment operator defined in
rfb::Configuration when the dialog is opened (options = global) and when
the changes are OK'd (global = options). This has required a little more
rework than I would have liked, but that was mainly due to the fact that
many of the get/set methods in rfb::Configuration are implicitly linked to
the global config. This approach may not be better, I'm just tossing it
out as another idea.
-brian
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
