On Wed, 8 Aug 2012, Brian Hinz wrote:
Hi Peter,
I haven't tried this yet, but unless I've missed something, won't it cause the
values of the global parameters to be
changed when a config file is loaded? Without a rollback mechanism, if the
user then cancels the options dialog those
changes will still go into effect. I don't think that's the behavior that most
people would expect.
Loading is not done with the options dialog open, but from the main
window. Thus, you cannot "cancel" a load once it is done. The options are
then saved as default options when you click on Connect.
FWIW, I've been working on adding this functionality to the java viewer and
used an instance of an rfb::Configuration
object to hold temporary values of the parameters. That way, all of the
changes made in the dialog don't get committed
until the dialog is OK'd. The global config and options config are sync'd up
via the assignment operator defined in
rfb::Configuration when the dialog is opened (options = global) and when the
changes are OK'd (global = options). This
has required a little more rework than I would have liked, but that was mainly
due to the fact that many of the get/set
methods in rfb::Configuration are implicitly linked to the global config. This
approach may not be better, I'm just
tossing it out as another idea.
Perhaps it would be good if you try the native client implementation
first, to see how it works. You can get a Windows binary here:
http://www.cendio.com/~astrand/tigervnc/tmp/
Rgds,
---
Peter Åstrand ThinLinc Chief Developer
Cendio AB http://cendio.com
Teknikringen 8 http://twitter.com/ThinLinc
583 30 Linköping http://facebook.com/ThinLinc
Phone: +46-13-214600 http://plus.google.com/112509906846170010689
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
