On Wed, 16 Jan 2013, DRC wrote:
On 1/16/13 3:12 AM, Peter Åstrand wrote:
Sure, but we don't have the details. It's not very useful to submit a
bug report that says "it fails on some machines but not mine" :-)
Didn't I just supply the details? And a fix?
Yes, a fix, but I don't understand on which machines this is failing, or
why.
Really, it's much better if you communicate with the FLTK upstream
directly. We have no special communication channels.
No, because this is a bug introduced by the patches that Cendio made to
FLTK. All I'm suggesting is to extend fltk-1_v6.3.x-keyboard-osx.patch
so that it adds '-framework Carbon' in the CMake build system the same
way it already does in the autotools build system. Don't see why you
have to wait for 1.3.2 for that, since this is not an upstream problem.
It's a problem created by an FLTK patch that was specifically made for
the purposes of TigerVNC.
Ok, that makes sense. Would it be possible for you to extend the patch
in this way? We do not build FLTK with CMake.
Well, if you don't build FLTK with CMake, then why does the documented
procedure for building FLTK (in BUILDING.txt) require CMake?
I think this was my mistake. If I remember correctly, I assumed that we
were also building FLTK with CMake and didn't check this. One advantage
though is that it imposes fewer dependencies. For example, if you are
building on Windows, I suppose building with Autotools requires you to
install more packages(?).
This is the basic problem I've been complaining about all along-- a
fundamental disconnect between what users of the open source code are
expected to do and what Cendio actually tests. In other words, you guys
need to eat your own dog food.
We are working in this direction. Removing the in-tree FLTK version was
one such step. We are not using it, so it constantly got out of sync.
Nowadays, the documentation in BUILDING.txt is directly copied from our
build scripts, and we are documenting and recommending exactly that FLTK
version and those patches that we are actually using.
I think it's unfortunate that FLTK is trying to support two different
build systems. My experience is that this never works. Accordingly, I have
opened up http://www.fltk.org/str.php?L2916 .
Anyway, in the mean time, the question is if we should start building FLTK
with CMake, or if we should change the documentation to recommend
Autotools instead? When looking in the FLTK repository, it seems to me
that the CMake build system gets less attention than the Autotools one,
and is constantly lagging behind. For example, configure.in says we are at
FLTK 1.3.1, while CMakeLists.txt says 1.3.0. There are several bug reports
of that the CMake files are out of sync, for example
http://www.fltk.org/str.php?L2088 .
My suggestion is therefore that we start recommending building FLTK with
Autotools instead. Ok with everyone?
I prefer vncviewer/CMakeLists.txt. In our build, we have actually added
this:
if(UNIX AND NOT APPLE)
# Needed to load icon files
target_link_libraries(vncviewer -Wl,-Bstatic ${FLTK_IMAGES_LIBRARY}
png -Wl,-Bdynamic)
endif()
So add it to everyone's build, then.
We have additional makefile tweaks; we'll need to check if they are
required as well. I'll see if I can find some time for this.
Yes, we should make it as easy as possible. Shouldn't be necessary to
tweak FLTK though; linking libgcc and libstdc++ statically can be done
from the TigerVNC make files.
Try it. I think you'll find, as I did, that it doesn't work that way.
It works in our build system, so I'm sure it's possible. I'm not saying
that it's easy though...
Rgds,
---
Peter Åstrand ThinLinc Chief Developer
Cendio AB http://cendio.com
Teknikringen 8 http://twitter.com/ThinLinc
583 30 Linköping http://facebook.com/ThinLinc
Phone: +46-13-214600 http://plus.google.com/112509906846170010689
------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612
_______________________________________________
Tigervnc-devel mailing list
Tigervnc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
