On Thu, 30 Apr 2009 17:43:53 +0100
"Daniel P. Berrange" <d...@berrange.com> wrote:

> On Thu, Apr 30, 2009 at 02:44:56PM +0200, Pierre Ossman wrote:
> > There exists client that send repeated "down" events on automatic key
> > repeats, and those that send pairs of "up" and "down". Usually this
> > behaviour depends on the platform on which the client runs.
> > 
> > Since only the repeated "down" case allows the server to tell the
> > difference between automatic and manual key repeats, clarify that the
> > "down" repeat method is the preferred.
> 
> FWIW, gtk-vnc used to accidentally handle key repeat by sending
> repeated "down" events with no corresponding up events. This 
> confused some servers, such that no they only registered the
> first, and then ignored all following 'down' events. So we 
> switched GTK-VNC over to generating explict down+up events when
> keyrepeating

Tough luck unfortunately. There are already major clients of both
versions, so the reality is that server will have to deal with it. The
point of this patch was to clarify which is preferred so that we can
steer new implementation in a desirable direction.

> 
> It is also not, in general, possible to mandate that key repeat
> takes place on the client. Where VNC the server is attached to
> a X server / other desktop service, it might be possible to disable
> server side repeat, but in the case of a VNC server attached to
> a virtual machine this is impossible. The VNC server has no control
> over how the X server inside the guest deals with key presses.
> 

Indeed. The text was supposed to be read with RFC terminology in mind.
I.e. the "should" is to be read as "to the extent possible, but
deviations are allowed". From what I can tell, repeats are handled
client side in the major clients out there today.

And for clients that follow the behaviour of sending just "down"
events, determining which events to ignore for a server that wants to
do its own repeat is trivial.

Rgds
-- 
Pierre Ossman            OpenSource-based Thin Client Technology
System Developer         Telephone: +46-13-21 46 00
Cendio AB                Web: http://www.cendio.com

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations 
Conference from O'Reilly Media. Velocity features a full day of 
expert-led, hands-on workshops and two days of sessions from industry 
leaders in dedicated Performance & Operations tracks. Use code vel09scf 
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
_______________________________________________
tigervnc-rfbproto mailing list
tigervnc-rfbproto@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tigervnc-rfbproto

Reply via email to