Hi Ken,

Here's my take on the below:

> 
> 1. How long should a patch typically bake before being committed?
> 

Depends on the project usually. Some, which have been around for a while,
seem to have stricter policies on this than others. Over here in Tika ville,
if you feel it's something controversial, 1-2 days should give everyone
enough time to check out the patch (unless it's over the holidays in which
you should leave a little bit more lag-time, maybe a week).

In general though, if it's not controversial and just adds functionality,
without changing core interfaces, etc., I think you are OK to move forward a
bit faster, so long as you follow the process (JIRA issue + comments + unit
tests [if they make sense], and update to CHANGES.txt on anything
non-trivial).

> This came up because I thought about filing an issue + patch, and then
> trying to commit it for the 0.6 release, but that wouldn't give any
> time for review.

There's time I think -- I plan on trying to cut the first RC sometime next
week. So if you can get to it before then and throw up a patch in the next
day or so, you should be OK.

> 2. How do you handle svn + git?

I don't :) I'm an SVN guy, so I don't have much of an opinion on git.

> 
> E.g. do you always generate your patches in git, and then roll patches
> into SVN using Eclipse?
> 

I think this varies depending on the editor of preference. I typically use
Eclipse + Subclipse, so I just generate patches from Eclipse. Others use
vi/emacs + SVN or vi/emacs + git. I think the requirement is that your patch
should apply with little or (preferably) no warnings to a clean checkout of
the trunk using the UNIX patch tool.

HTH, and, welcome again!

Cheers,
Chris


++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Chris Mattmann, Ph.D.
Senior Computer Scientist
NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
Office: 171-266B, Mailstop: 171-246
Email: chris.mattm...@jpl.nasa.gov
WWW:   http://sunset.usc.edu/~mattmann/
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Adjunct Assistant Professor, Computer Science Department University of
Southern California, Los Angeles, CA 90089 USA
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++


Reply via email to