On Dec 18, 2009, at 1:15 PM, Ken Krugler wrote: > Hi current committers, > > A few quick questions about commit policies/process: > > 1. How long should a patch typically bake before being committed? > > I've heard that a few days is considered good, to give everybody a chance to > weigh in on whether the patch should be committed or not.
It's usually a judgment call. If it is trivial, I usually just do it. If it touches a lot of files, public APIs or changes some sig. functionality, then I tend to add something to JIRA like: "I plan on committing in X days" or something to that effect. Things can always be reverted, so it's never that big of a deal if it messes up (although it's generally good not to break the build and not to break public APIs, but that depends on the project, too.) -Grant
