Le lundi 23 juin 2014, 23:56:10 jiang a écrit : > I'll push a patch. I'll take this as "I'd like to commit/push this patch, what do you think of it?"
The patch itself looks good but it would be better if you add a testcase that would fail without your patch. You already have a program that exhibit the bug, you just need to transform it so that it returns 0 if tcc behaves correctly and 1 else. I also have a minor nitpick: "\'%s\' may not appear in parameter list", get_tok_str(var, NULL) That is, use single quote and put the symbol at the beginning of the sentence, that would avoid the colon. If you fix those (testcase is very important), you are welcome to commit/push your patch. In the future it would be better if you provide a patch as given by git format-patch. This way we'd have the message that you intend to use in your commit. And finally please try to find a title more specific than "Request push". Try to find a title that explain what you want to fix. In this case you could choose "Fix identifier list parsing". If you can refer to a section in C99 standard in your message and your commit message that's the icing on the cake but we don't do it systematically ourselves. However I think it is good practice as GCC can sometimes deviate from the standard and we should try to adhere to the standard, not follow GCC blindly. Thanks for your patch. Best regards, Thomas
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Tinycc-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/tinycc-devel
