Le mardi 30 décembre 2014, 11:05:15 Sergey Korshunoff a écrit : > Problem: configure in 32bit userspace running on 64bit kernel is > trying to compile tcc for ARCH=x86_64. Expecting behavior: to > configure a tcc for ARCH=x86 > > This patch will allow to specify/configure a target cpu. Examples: > ARCH=x86 ./configure > ARCH=x86_64 ./configure > > If ARCH is not specified then try to detect a current cpu type by > examining arch of the host_cc.
The principle is nice but the code style looks different from the rest and a bit complicated for what it is. Why using a subscript for instance? Why not nesting if? Finally, you could instead of using readelf use a carefully crafted conftest that would give you whether userspace is 32bit of 64bit. The structure would then look like this: if ARCH is defined, then use it else use uname if cpu is x86_64 and conftest gives 32bit, cpu=i386. What do you think? Best regards, Thomas _______________________________________________ Tinycc-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/tinycc-devel
