On Tue, Dec 30, 2014 at 10:56 PM, Sergey Korshunoff <[email protected]> wrote: > A revised patch (was called a wrong function) > > 2014-12-28 7:54 GMT+03:00, Sergey Korshunoff <[email protected]>: >> Call a tcc_add_file(0, ""); at the end of files handling to free a >> preprocessor defines.
I have a few questions: 1. it looks like the comment does not match the code change; 2. this patch does not include which function it changed, and it is difficult to find out, add -p to diff to add function information, or use git diff directly; 3. in the added code, the position of that comment does not look right; 4. and finally, if you pass a NULL pointer to tcc_preprocess and this statement is executed, it should cause a crash immediately. Sincerely, Lee _______________________________________________ Tinycc-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/tinycc-devel
