Hi tcc mailing list, Looking at recent mob commits, I had a few comments on two recent commits for the riscv64 backend. "riscv64: enable gen_clear_cache with I-cache flushing" https://repo.or.cz/tinycc.git/commit/6b5346534746d4e81525109869b836359175ba1d
It's a relatively small thing, but I don't really like the addition `__clear_cache` in it's own file (`lib/riscvflush.c`). I think putting either in libtcc1.c or lib-arm64.c would make more sense (since that seems to be the place for riscv64 and arm64 compiler intrinsics at this point). If neither of those options are acceptable, I would suggest making something like `lib-riscv.c` for riscv specific intrinsics instead of one dedicated to cache clearing functions. Personally, I would be in favor of refactoring the soft-float functions out of `lib-arm64.c` into their own file, but that's a different topic. Thanks, -Sam Ellicott Soli Deo Gloria
_______________________________________________ Tinycc-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/tinycc-devel
