On 28.07.2026 14:38, Mounir IDRASSI via Tinycc-devel wrote:
Hi Richard,

Thanks for the detailed report and, especially, for testing the fix with a real 
libgc build on FreeBSD. The missing plain symbols were indeed the root cause.

I pushed the resulting work to mob as two commits:

Hi,

I'd normally recommend not to push other people's work, for several
reasons, such as authorship or precision wrt. addressing a real problem.

Btw. convention with commit messages is to break lines at length
of 40 or so.  Otherwise hard to read them in gitk or web interfaces.

As always, the more lines a patch has the more more problems it tends
to have.  For example

 char end = 7;

Obviously under no circumstances this can mean the end of something
and have value '7' at the same time.

        if (!(s->sh_flags & SHF_WRITE))

Not sure whether tcc would want .plt or .note.ABI-tag count as text
sections.

So, before we throw even more code at that maybe we should just go
with Richards original simple 3 line patch?  WDY think?

...etc

_______________________________________________
Tinycc-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

Reply via email to