This is ok with me, but I do have a couple of suggestions. See below. > -----Original Message----- > From: Mohan Krishna Ghanta Krishnamurthy > Sent: Wednesday, 30 May, 2018 16:01 > To: [email protected]; Jon Maloy > <[email protected]>; [email protected]; > [email protected]; Mohan Krishna Ghanta Krishnamurthy > <[email protected]> > Subject: [iproute2-next 0/1] tipc: Extrend ss for tipc groupcomm info > > The following patch adds the ability to dump necessary tipc socket group > communication information with the option --tipcgroup. > > Example output : > # ss --tipc --tipcgroup > State Recv-Q Send-Q Local > Address:Port Peer Address:Port
Elsewhere, I now use the term "node number" or "node hash number" instead of node address, which I think can be misunderstood. I think simply Local Node:Port and Peer Node:Port would look better. > LISTEN 0 0 > 16781314:1012617198 Elsewhere, I consistently present node numbers in hex format. It is more compact, and it becomes easer to see that it is a node number, not a port number. > - > UNCONN 0 0 > 16781314:2406851268 > - grpid:2222 mbrid:1 grpstate:closed bc_snd_nxt:2820 Will you add "open/not open" and member listings later? ///jon > grpscope:cluster > UNCONN 0 0 > 16781314:1409434348 > - grpid:1111 mbrid:100 grpstate:open bc_snd_nxt:2 > grpscope:cluster > ESTAB 0 0 > 16781314:4057061760 > 0:2385232319 > UNCONN 0 0 > 16781314:3892787179 > - grpid:1111 mbrid:0 grpstate:open bc_snd_nxt:0 > grpscope:cluster > ESTAB 0 0 > 16781314:2385232319 > 0:4057061760 > > GhantaKrishnamurthy MohanKrishna (1): > tipc: Extend ss for tipc-socket groupcomm info > > include/uapi/linux/tipc_netlink.h | 14 ++++++++++++++ > misc/ss.c | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 47 insertions(+) > > -- > 2.1.4 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tipc-discussion
