Hi Jon, Please find the response below.
Thanks & Regards, Mohan On Fri, Jun 8, 2018 at 12:46 PM, Jon Maloy <jon.ma...@ericsson.com> wrote: > This is ok with me, but I do have a couple of suggestions. See below. > > > -----Original Message----- > > From: Mohan Krishna Ghanta Krishnamurthy > > Sent: Wednesday, 30 May, 2018 16:01 > > To: tipc-discussion@lists.sourceforge.net; Jon Maloy > > <jon.ma...@ericsson.com>; ma...@donjonn.com; > > ying....@windriver.com; Mohan Krishna Ghanta Krishnamurthy > > <mohan.krishna.ghanta.krishnamur...@ericsson.com> > > Subject: [iproute2-next 0/1] tipc: Extrend ss for tipc groupcomm info > > > > The following patch adds the ability to dump necessary tipc socket group > > communication information with the option --tipcgroup. > > > > Example output : > > # ss --tipc --tipcgroup > > State Recv-Q Send-Q > Local Address:Port Peer Address:Port > > Elsewhere, I now use the term "node number" or "node hash number" instead > of node address, which I think can be misunderstood. > I think simply Local Node:Port and Peer Node:Port would look better. > Since SS is a iproute2 tool,"Local Address:Port " and "Peer Address:Port" is common for all the sockets. I cannot modify this. > > > > LISTEN 0 0 > 16781314:1012617198 > > Elsewhere, I consistently present node numbers in hex format. It is more > compact, and it becomes easer to see that it is a node number, not a port > number. > I will modify local address and peer address to hex. > > > > - > > UNCONN 0 0 > 16781314:2406851268 > > - grpid:2222 mbrid:1 *grpstate:closed* > bc_snd_nxt:2820 > > Will you add "open/not open" and member listings later? > I added groupstate as "closed" and "open". Please let me know if I should change it to "not open" Reg: Member listings- I am not sure what to add . Each group has different members with node:port information. ss provides all TIPC sockets information with group id. Since there are multiple sockets with the same group id in a local node, there may be lot of member lists with duplicate info. Also, my recommendation would be to add a seperate tipc command for group info, and print member listing there than sock info. Please let me know your views. > ///jon > > > grpscope:cluster > > UNCONN 0 0 > 16781314:1409434348 > > - grpid:1111 mbrid:100 grpstate:open bc_snd_nxt:2 > > grpscope:cluster > > ESTAB 0 0 > 16781314:4057061760 > > 0:2385232319 > > UNCONN 0 0 > 16781314:3892787179 > > - grpid:1111 mbrid:0 grpstate:open bc_snd_nxt:0 > grpscope:cluster > > ESTAB 0 0 > 16781314:2385232319 > > 0:4057061760 > > > > GhantaKrishnamurthy MohanKrishna (1): > > tipc: Extend ss for tipc-socket groupcomm info > > > > include/uapi/linux/tipc_netlink.h | 14 ++++++++++++++ > > misc/ss.c | 33 ++++++++++++++++++++++++++++++ > +++ > > 2 files changed, 47 insertions(+) > > > > -- > > 2.1.4 > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > tipc-discussion mailing list > tipc-discussion@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tipc-discussion > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ tipc-discussion mailing list tipc-discussion@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tipc-discussion
