I just made my own fix, and I have (very) lightly tested it.
There were two problems with the way a message was "confirmed" by the URL
method, since it is actually just released from the queue:
1) If "CONFIRM_APPEND" was defined, the resulting webpage would tell you
that "no further confirmation" would be needed, without actually adding
the address to the CONFIRM_APPEND list.
2) If "PENDING_RELEASE_APPEND" is defined (and not CONFIRM_APPEND), I
think that the webpage would NOT tell you that "no further confirmation"
would be needed, but the address would indeed be added to the
PENDING_RELEASE_APPEND list.
I have now solved both problems, I think. If PENDING_RELEASE_APPEND is
defined, the webpage will say that no further confirmation is needed, and
add the address to the PENDING_RELEASE_APPEND list. If CONFIRM_APPEND is
defined, the webpage will say that no further confirmation is needed, and
add the address to the CONFIRM_APPEND list. If both are defined, the
address is only added to the PENDING_RELEASE_APPEND list. I think.
Here is the patch for contrib/cgi/Release.py that should do it:
--------------------------------SNIP------------------------------
--- Release.py.orig Fri Jan 10 13:31:59 2003
+++ Release.py Fri Jan 10 14:23:49 2003
@@ -126,14 +126,21 @@
print "</table><br>"
- if Defaults.CONFIRM_APPEND:
+ if Defaults.CONFIRM_APPEND or Defaults.PENDING_RELEASE_APPEND:
ConfirmAddr = Util.confirm_append_address \
(
parseaddr(MsgObj.msgobj["x-primary-address"])[1],
parseaddr(MsgObj.msgobj["return-path"])[1]
)
- print "Future e-mails from <tt>%s</tt> will not have to be confirmed." % \
- ConfirmAddr
+ if ConfirmAddr and \
+ ( Defaults.PENDING_RELEASE_APPEND \
+ or \
+ ( Defaults.CONFIRM_APPEND and \
+ ( Util.append_to_file( ConfirmAddr, Defaults.CONFIRM_APPEND ) != 0 ) \
+ ) \
+ ):
+ print "Future e-mails from <tt>%s</tt> will not have to be confirmed." % \
+ ConfirmAddr
print """ </td>
</tr>
-------------------------------ENDSNIP----------------------------
In case I didn't make it clear earlier, this hasn't really been tested
other than by me, and I don't use PENDING_RELEASE_APPEND at all. At the
very least it now truly adds an address to CONFIRM_APPEND if it's set.
I hope someone may find this useful - I know I do :)
Jim Ramsay
_____________________________________________
tmda-users mailing list ([EMAIL PROTECTED])
http://tmda.net/lists/listinfo/tmda-users
