"Rachel Ellis" <[EMAIL PROTECTED]> writes: > this patch moves the "file store" functionality of FilterParser into > FilterStore, which defines a set of classes that each implement a > contains(self, keys) method. This substantially simplifies firstmatch. > > I also made "-optional" the default (and only) behavior. I see no reason > why any user would want tmda to die because he didn't create a file that he > intends to create later or let auto-append create for him. It does, > however, note w/ syslog when it can't find such files. (Writing a Log class > that allows using LOGFILE_DEBUG with as much ease as I can use syslog would > be a nice improvment, but I didn't want to delay this patch longer.) > > Finally, I removed the ability to override the from-file action with a > per-line action w/in the file. IMO, these should be grouped in another > file, or in the top-level spec as plain From lines if there are few enough. > I could argue at length why this is a Good Change, but I'll condense it to > an analogy: if we wanted "more than one way to do it" we'd be coding in > perl.
What do you think about these changes Tim? _________________________________________________ tmda-workers mailing list ([EMAIL PROTECTED]) http://tmda.net/lists/listinfo/tmda-workers
